RFR: 8335553: [Graal] Compiler thread calls into jdk.internal.vm.VMSupport.decodeAndThrowThrowable and crashes in OOM situation [v2]

[Doug Simon]

On Tue, 9 Jul 2024 14:37:47 GMT, Yudi Zheng <yzheng at openjdk.org> wrote:

>> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed TestTranslatedException
>
> src/hotspot/share/jvmci/jvmciCompilerToVM.cpp line 782:
> 
>> 780:       while (true) {
>> 781:         // Trigger an OutOfMemoryError
>> 782:         objArrayOop next = oopFactory::new_objectArray(0x7FFFFFFF, CHECK_NULL);
> 
> Shall we check for pending exception and break here?

The `CHECK_NULL` macro effectively does that.

> test/jdk/jdk/internal/vm/TestTranslatedException.java line 167:
> 
>> 165:     private static void assertThrowableEquals(Throwable originalIn, Throwable decodedIn) {
>> 166:         Throwable original = originalIn;
>> 167:         Throwable decoded = decodedIn;
> 
> What is the purpose of this renaming?

So that the printing down the bottom of this message shows the complete throwable, not just the cause on which the comparison failed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20083#discussion_r1670656254
PR Review Comment: https://git.openjdk.org/jdk/pull/20083#discussion_r1670654917