RFR: 8334755: Asymptotically faster implementation of square root algorithm [v22]

fabioromano1 duke at openjdk.org
Tue Jul 9 20:03:21 UTC 2024


> I have implemented the Zimmermann's square root algorithm, available in works [here](https://inria.hal.science/inria-00072854/en/) and [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root).
> 
> The algorithm is proved to be asymptotically faster than the Newton's Method, even for small numbers. To get an idea of how much the Newton's Method is slow,  consult my article [here](https://arxiv.org/abs/2406.07751), in which I compare Newton's Method with a version of classical square root algorithm that I implemented. After implementing Zimmermann's algorithm, it turns out that it is faster than my algorithm even for small numbers.

fabioromano1 has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 53 additional commits since the last revision:

 - Merge branch 'openjdk:master' into patchSqrt
 - Ensure normalized value in MutableBigInteger initialization with ints
 - Merge branch 'openjdk:master' into patchSqrt
 - Added documentation
 - An optimization
 - Reverted changes in BigDecimal
 - Merge branch 'openjdk:master' into patchSqrt
 - Added "throw" to throw the ArithmeticException created
 - Correct BigDecimal.sqrt()
 - Simplified computing square root of BigDecimal using BigInteger.sqrt()
 - ... and 43 more: https://git.openjdk.org/jdk/compare/aa8fe60e...9aa7fdca

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19710/files
  - new: https://git.openjdk.org/jdk/pull/19710/files/b28f034b..9aa7fdca

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19710&range=21
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19710&range=20-21

  Stats: 11590 lines in 439 files changed: 7143 ins; 2562 del; 1885 mod
  Patch: https://git.openjdk.org/jdk/pull/19710.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19710/head:pull/19710

PR: https://git.openjdk.org/jdk/pull/19710


More information about the core-libs-dev mailing list