RFR: 8335935: Chained builders not sending transformed models to next transforms

Adam Sotona asotona at openjdk.org
Wed Jul 10 07:26:19 UTC 2024


On Tue, 9 Jul 2024 17:34:14 GMT, Chen Liang <liach at openjdk.org> wrote:

> Please review the fix for a major transformation bug within the ClassFile API, where certain kinds of buffered elements produced by one transform is not sent to the next, and the "chained" (`andThen` transformation chains) builders returning the wrong builder for call chains.
> 
> This is intended to be backported to JDK 23, as this has significant impact on user experience with ClassFile API transformations. The backport won't be clean as we already renamed `ClassFile.transform` to `transformClass`, which will be reverted in the backport.

It looks good to me.
Nice job!

-------------

Marked as reviewed by asotona (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20100#pullrequestreview-2168251509


More information about the core-libs-dev mailing list