RFR: 8333446: Add tests for hierarchical container support [v3]
Jan Kratochvil
jkratochvil at openjdk.org
Thu Jul 11 03:41:59 UTC 2024
On Mon, 1 Jul 2024 14:43:58 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> Please review this PR which adds test support for systemd slices so that bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be verified. The added test, `SystemdMemoryAwarenessTest` currently passes on cgroups v1 and fails on cgroups v2 due to the way how [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) was implemented when JDK 13 was a thing. Therefore immediately problem-listed. It should get unlisted once [JDK-8322420](https://bugs.openjdk.org/browse/JDK-8322420) merges.
>>
>> I'm adding those tests in order to not regress another time.
>>
>> Testing:
>> - [x] Container tests on Linux x86_64 cgroups v2 and Linux x86_64 cgroups v1.
>> - [x] New systemd test on cg v1 (passes). Fails on cg v2 (due to JDK-8322420)
>> - [x] GHA
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Merge branch 'master' into jdk-8333446-systemd-slice-tests
> - Merge branch 'master' into jdk-8333446-systemd-slice-tests
> - Fix comments
> - 8333446: Add tests for hierarchical container support
test/hotspot/jtreg/ProblemList.txt line 119:
> 117: containers/docker/TestMemoryAwareness.java 8303470 linux-all
> 118: containers/docker/TestJFREvents.java 8327723 linux-x64
> 119: containers/systemd/SystemdMemoryAwarenessTest.java 8322420 linux-all
This line should be removed as long as it gets applied after [17198](https://github.com/openjdk/jdk/pull/17198).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19530#discussion_r1673356918
More information about the core-libs-dev
mailing list