RFR: 8336259: Wrong link to stylesheet.css in JavaDoc API documentation
Nizar Benalla
nbenalla at openjdk.org
Thu Jul 11 21:02:03 UTC 2024
Can I please get a review for this small change, the relative link to the stylesheet isn't needed as it wasn't used anyway in the generated HTML. The correct link to the stylesheet is already in the generated HTML.
This is the difference between the generated docs before and after this change, by running `diff -r` on the docs before and after the change.
GeneratedDocs % diff -r 8336259-stylesheet old-docs
diff -r 8336259-stylesheet/api/java.base/java/lang/doc-files/ValueBased.html old-docs/api/java.base/java/lang/doc-files/ValueBased.html
13a14
> <link rel="stylesheet" type="text/css" href="../../../../stylesheet.css" title="Style">
diff -r 8336259-stylesheet/api/java.base/java/lang/doc-files/threadPrimitiveDeprecation.html old-docs/api/java.base/java/lang/doc-files/threadPrimitiveDeprecation.html
13a14
> <link rel="stylesheet" type="text/css" href="../../../../stylesheet.css" title="Style">
Here is the link for the generated docs after the change, no visual change is seen but the erronous link is gone.
Value based classes [before](https://docs.oracle.com/en%2Fjava%2Fjavase%2F22%2Fdocs%2Fapi%2F%2F/java.base/java/lang/doc-files/ValueBased.html) - [after](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336259-stylesheet/api/java.base/java/lang/doc-files/ValueBased.html)
Java Thread Primitive Deprecation [before](https://docs.oracle.com/en%2Fjava%2Fjavase%2F22%2Fdocs%2Fapi%2F%2F/java.base/java/lang/doc-files/threadPrimitiveDeprecation.html) - [after](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336259-stylesheet/api/java.base/java/lang/doc-files/threadPrimitiveDeprecation.html)
-------------
Commit messages:
- (C)
- remove incorrect link to stylesheet
Changes: https://git.openjdk.org/jdk/pull/20145/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20145&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8336259
Stats: 4 lines in 2 files changed: 0 ins; 2 del; 2 mod
Patch: https://git.openjdk.org/jdk/pull/20145.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/20145/head:pull/20145
PR: https://git.openjdk.org/jdk/pull/20145
More information about the core-libs-dev
mailing list