RFR: 8336259: Wrong link to stylesheet.css in JavaDoc API documentation
duke
duke at openjdk.org
Fri Jul 12 06:36:51 UTC 2024
On Thu, 11 Jul 2024 20:55:29 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:
> Can I please get a review for this small change, the relative link to the stylesheet isn't needed as it wasn't used anyway in the generated HTML. The correct link to the stylesheet is already in the generated HTML.
>
> This is the difference between the generated docs before and after this change, by running `diff -r` on the docs before and after the change.
>
>
> GeneratedDocs % diff -r 8336259-stylesheet old-docs
> diff -r 8336259-stylesheet/api/java.base/java/lang/doc-files/ValueBased.html old-docs/api/java.base/java/lang/doc-files/ValueBased.html
> 13a14
>> <link rel="stylesheet" type="text/css" href="../../../../stylesheet.css" title="Style">
> diff -r 8336259-stylesheet/api/java.base/java/lang/doc-files/threadPrimitiveDeprecation.html old-docs/api/java.base/java/lang/doc-files/threadPrimitiveDeprecation.html
> 13a14
>> <link rel="stylesheet" type="text/css" href="../../../../stylesheet.css" title="Style">
>
>
> Here is the link for the generated docs after the change, no visual change is seen but the erronous link is gone.
> Value based classes [before](https://docs.oracle.com/en%2Fjava%2Fjavase%2F22%2Fdocs%2Fapi%2F%2F/java.base/java/lang/doc-files/ValueBased.html) - [after](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336259-stylesheet/api/java.base/java/lang/doc-files/ValueBased.html)
>
> Java Thread Primitive Deprecation [before](https://docs.oracle.com/en%2Fjava%2Fjavase%2F22%2Fdocs%2Fapi%2F%2F/java.base/java/lang/doc-files/threadPrimitiveDeprecation.html) - [after](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336259-stylesheet/api/java.base/java/lang/doc-files/threadPrimitiveDeprecation.html)
@nizarbenalla
Your change (at version 504f2b2dd0787d453618538b18b55c99f353d6db) is now ready to be sponsored by a Committer.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20145#issuecomment-2224893741
More information about the core-libs-dev
mailing list