RFR: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts [v2]

SendaoYan syan at openjdk.org
Fri Jul 12 07:39:11 UTC 2024


On Fri, 12 Jul 2024 07:05:58 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   make variable TOOL_VM_OPTIONS to private
>
> test/jdk/tools/jlink/JLinkReproducibleTest.java line 41:
> 
>> 39: public class JLinkReproducibleTest {
>> 40: 
>> 41:     static final String TOOL_VM_OPTIONS = System.getProperty("test.tool.vm.opts", "");
> 
> Nit - this can be made `private`

Thanks for the review. The variable has made to private.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19669#discussion_r1675445554


More information about the core-libs-dev mailing list