RFR: 8334755: Asymptotically faster implementation of square root algorithm [v23]

Raffaello Giulietti rgiulietti at openjdk.org
Fri Jul 12 13:36:53 UTC 2024


On Fri, 12 Jul 2024 13:28:14 GMT, fabioromano1 <duke at openjdk.org> wrote:

>> src/java.base/share/classes/java/math/MutableBigInteger.java line 128:
>> 
>>> 126:             intLen = 2;
>>> 127:             value[0] = hi;
>>> 128:             value[1] = (int) val;
>> 
>> Suggestion:
>> 
>>             value = new int[] {hi, (int) val}
>>             intLen = 2;
>
> In this case, should the same method be applied in the inizialization with an int?

You mean, in `init()`? Then yes, please.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19710#discussion_r1675937382


More information about the core-libs-dev mailing list