RFR: 8334755: Asymptotically faster implementation of square root algorithm [v23]

[fabioromano1]

On Fri, 12 Jul 2024 13:07:39 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> fabioromano1 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added comment on normalization in MutableBigInteger.sqrtRemZimmermann()
>
> src/java.base/share/classes/java/math/MutableBigInteger.java line 2020:
> 
>> 2018:          * The length is normalized to a mutiple of 4 because, in this way,
>> 2019:          * the input can be always split in blocks of words without twiddling with bits.
>> 2020:          */
> 
> What's substantially different here from the Bertot, Magaud, Zimmermann paper?
> This is not explained in detail, so it is way harder to understand than the paper.

In the paper, the number is normalized to an even number of words... but this is not done in the pseudocode, since the pseudocode assumes that the number is already normalized, so actually there's no substantial difference...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19710#discussion_r1675978798