RFR: 8334755: Asymptotically faster implementation of square root algorithm [v23]

[fabioromano1]

On Fri, 12 Jul 2024 13:08:29 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> fabioromano1 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added comment on normalization in MutableBigInteger.sqrtRemZimmermann()
>
> src/java.base/share/classes/java/math/MutableBigInteger.java line 2040:
> 
>> 2038:         sqrt.add(q);
>> 2039: 
>> 2040:         MutableBigInteger chunk = u;
> 
> I don't get the need for `chunk`. It should be possible to use `u` directly.
> Is it for readability? Then maybe use a more "mathematical" name.

Ok, but what should the name be?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19710#discussion_r1675996081