RFR: 8334755: Asymptotically faster implementation of square root algorithm [v23]

Raffaello Giulietti rgiulietti at openjdk.org
Fri Jul 12 14:44:55 UTC 2024


On Fri, 12 Jul 2024 14:20:23 GMT, fabioromano1 <duke at openjdk.org> wrote:

>> Ok, but what should the name be?
>
> Like `u_a0`? It is the most "mathematical" name that comes to my mind.

In the paper `u` is called R'', so I'd rename it as `rpp` (for R prime prime). Generally, the more the names in the code match the ones in the paper, the easier it becomes to read the code with the paper at hand.

Then you can then use `u` rather than `chunk`, but with a comment like "this corresponds to R'' L + N_0 in the paper".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19710#discussion_r1676042479


More information about the core-libs-dev mailing list