RFR: 8334755: Asymptotically faster implementation of square root algorithm [v23]
Raffaello Giulietti
rgiulietti at openjdk.org
Fri Jul 12 15:15:52 UTC 2024
On Fri, 12 Jul 2024 14:55:19 GMT, fabioromano1 <duke at openjdk.org> wrote:
>> In the paper `u` is called R'', so I'd rename it as `rpp` (for R prime prime). Generally, the more the names in the code match the ones in the paper, the easier it becomes to read the code with the paper at hand.
>>
>> Then you can then use `u` rather than `chunk`, but with a comment like "this corresponds to R'' L + N_0 in the paper".
>
> Actually, `u` is the name used by Zimmermann in the first paper.
That paper, while very concise, is not very "operational".
Anyway, adherence to the names of one of the paper (I prefer the 2nd, more detailed one) is very helpful.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19710#discussion_r1676085563
More information about the core-libs-dev
mailing list