RFR: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts [v2]
Jaikiran Pai
jpai at openjdk.org
Sat Jul 13 01:54:55 UTC 2024
On Fri, 12 Jul 2024 07:39:11 GMT, SendaoYan <syan at openjdk.org> wrote:
>> Hi all,
>> Currently, the testcase `test/jdk/tools/jlink/JLinkReproducibleTest.java` doesn't receive jvm options from jtreg.
>> I think it's necessory to receive jvm options from jtreg.
>> Fix solution similar to [JDK-8157850](https://bugs.openjdk.org/browse/JDK-8157850), the change has been verified, only change the testacase, the risk is low.
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>
> make variable TOOL_VM_OPTIONS to private
The changes look good to me and the testing shows no related failures.
-------------
Marked as reviewed by jpai (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19669#pullrequestreview-2176039655
More information about the core-libs-dev
mailing list