RFR: 8335480: Only deoptimize threads if needed when closing shared arena [v2]
Uwe Schindler
uschindler at openjdk.org
Mon Jul 15 09:00:53 UTC 2024
On Mon, 15 Jul 2024 08:57:08 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>>
>> track has_scoped_access for compiled methods
>
> test/micro/org/openjdk/bench/java/lang/foreign/ConcurrentClose.java line 34:
>
>> 32: import static java.lang.foreign.ValueLayout.*;
>> 33:
>> 34: @BenchmarkMode(Mode.AverageTime)
>
> Doesn't the existing bench `MemorySessionClose` already covers this? That benchmark has three stress modes, and one of them spawns many unrelated threads (but there is only one thread doing a close).
It should also run threads not doing any scoped accesses to verify that other threads are not affected.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20158#discussion_r1677509975
More information about the core-libs-dev
mailing list