RFR: 8335922: Incorrect @Stable usage of LambdaForm$Name.index [v3]

Chen Liang liach at openjdk.org
Mon Jul 15 22:56:23 UTC 2024


On Mon, 15 Jul 2024 15:57:30 GMT, Chen Liang <liach at openjdk.org> wrote:

>> The `@Stable` on the `index` field is incorrect, as stable only avoids inlining `0`. On a strategic view, this index field should just become final so that `Name` becomes eligible for value class migration once valhalla comes. This patch makes the `index` field final and updates the usages correspondingly.
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Encapsulate offsetIndex, share computation result

I have reimplemented this patch to implement the "make `index` field final" approach, which is much cleaner and friendlier to valhalla. tier 1-3 tests pass.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20178#issuecomment-2229569211


More information about the core-libs-dev mailing list