RFR: 8334394: Race condition in Class::protectionDomain [v2]
Alan Bateman
alanb at openjdk.org
Tue Jul 16 13:02:54 UTC 2024
On Mon, 17 Jun 2024 15:24:27 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> Make sure `pd` is always the same object when `getProtectionDomain0` is null.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>
> explain why the test is related to the fix
Marked as reviewed by alanb (Reviewer).
test/jdk/java/lang/Class/ProtectionDomainRace.java line 61:
> 59: private static volatile Throwable failed = null;
> 60: public static void main(String[] args) throws Throwable {
> 61: var ac = (PrivilegedAction<? extends Object>) () -> null;
Did you mean to name the PrivilegedAction "ac"? It might be more readable to change this line to `PrivilegedAction<?> pa = () -> null;`.
-------------
PR Review: https://git.openjdk.org/jdk/pull/19752#pullrequestreview-2180164683
PR Review Comment: https://git.openjdk.org/jdk/pull/19752#discussion_r1679348512
More information about the core-libs-dev
mailing list