RFR: 8334755: Asymptotically faster implementation of square root algorithm [v28]

[Raffaello Giulietti]

On Wed, 17 Jul 2024 16:39:10 GMT, fabioromano1 <duke at openjdk.org> wrote:

>> Can try with the old release and the incorrect code again?
>> If the results disagree with newer releases then I'd be interested in which release you were using, as to analyze the generated code and possibly file a bug report for the JIT compiler team.
>
> @rgiulietti The strangest thing is that we were both convinced that we had correctly tested the code on all values, without finding counterexamples...

I was trying with my own code, the one with the additional `Math.rint()` invocation, and didn't notice that the code in the PR was using a `(long)` conversion directly.
So my throw-away mini-program was slightly different from yours.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19710#discussion_r1681371163