RFR: 8336479: Provide Process.waitFor(Duration) [v2]

Jaikiran Pai jpai at openjdk.org
Thu Jul 18 05:13:32 UTC 2024


On Wed, 17 Jul 2024 21:41:16 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Proposing a new overload method for `Process#waitFor()` which takes a `Duration` for the timeout value. This will reduce the possibility for making mistakes with the `TimeUnit` in the other overload method. A corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   ProcessTools overriding one-arg waitFor()

src/java.base/share/classes/java/lang/Process.java line 501:

> 499:         if (hasExited())
> 500:             return true;
> 501:         if (duration.isZero() || duration.isNegative())

Hello Naoto, I see that there's a `Duration.isPositive()` API. Should we use that here instead?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20220#discussion_r1682126873


More information about the core-libs-dev mailing list