RFR: 8331341: secondary_super_cache does not scale well: C1 and interpreter [v2]

Vladimir Ivanov vlivanov at openjdk.org
Thu Jul 18 20:09:33 UTC 2024


On Wed, 17 Jul 2024 17:15:32 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> src/hotspot/share/oops/klass.inline.hpp line 122:
>> 
>>> 120:     return true;
>>> 121: 
>>> 122:   bool result = lookup_secondary_supers_table(k);
>> 
>> Should `UseSecondarySupersTable` affect `Klass::search_secondary_supers` as well?
>
> I think not. It'd complicate C++ runtime for no useful reason.

On the other hand, if `-XX:-UseSecondarySupersTable` is intended solely for diagnostic purposes, then handling all possible execution modes uniformly is preferable, since it gives more confidence when troubleshooting seemingly related failures.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19989#discussion_r1683419259


More information about the core-libs-dev mailing list