RFR: 8336479: Provide Process.waitFor(Duration) [v3]
Naoto Sato
naoto at openjdk.org
Thu Jul 18 20:49:11 UTC 2024
On Thu, 18 Jul 2024 19:07:18 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Addressing review comments
>
> src/java.base/share/classes/java/lang/Process.java line 504:
>
>> 502: return false;
>> 503:
>> 504: return waitForNanos(TimeUnit.NANOSECONDS.convert(duration));
>
> I'd rather see one of these methods call the other, to make it easy keep the behavior in sync.
> The Duration can be extracted to nanos and call the existing method.
Fixed as you suggested.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20220#discussion_r1683484772
More information about the core-libs-dev
mailing list