RFR: 8336479: Provide Process.waitFor(Duration) [v5]

[Chen Liang]

On Thu, 18 Jul 2024 22:57:59 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removed a blank line
>
> src/java.base/share/classes/java/lang/Process.java line 504:
> 
>> 502:      */
>> 503:     public boolean waitFor(Duration duration) throws InterruptedException {
>> 504:         Objects.requireNonNull(duration, "duration");
> 
> Does this explicit null-check pull its weight here?

Maybe not, but when this method gets a custom implementation, people don't have to remember to add a null check at front so there's no path that misses the NPE. It isn't wrong, so I don't see a problem with this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20220#discussion_r1683588397