RFR: 8336254: Virtual thread implementation + test updates
Serguei Spitsyn
sspitsyn at openjdk.org
Fri Jul 19 08:00:36 UTC 2024
On Thu, 18 Jul 2024 11:18:08 GMT, Alan Bateman <alanb at openjdk.org> wrote:
> I will check but there are a few renames that have to keep the initial year. Also there are some new files that have been checked into the loom repo for a long time so they have their initial year too.
Okay, thanks.
>> test/jdk/java/lang/Thread/virtual/ThreadAPI.java line 1113:
>>
>>> 1111: @Test
>>> 1112: void testYield3() throws Exception {
>>> 1113: assumeTrue(VThreadScheduler.supportsCustomScheduler(), "No support for custom schedulers");
>>
>> Q: What was the reason to rename `testYield2()` to `testYield3()`?
>
> There are a lot of tests that can't be proposed to main line at this time because they depend on the object monitor work. This is one such "gap" where testYield2 can't be added. I can re-number them if you want to avoid the gap but there are other changes that rename several test methods so I'd prefer to leave it until then.
Okay, thanks.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20143#issuecomment-2238590482
PR Review Comment: https://git.openjdk.org/jdk/pull/20143#discussion_r1683973972
More information about the core-libs-dev
mailing list