RFR: 8333812: ClassFile.verify() can throw exceptions instead of returning VerifyErrors [v3]

[Chen Liang]

On Fri, 19 Jul 2024 08:26:46 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> `ClassFile.verify()` should always return list of verification errors and never throw an exception, even for corrupted classes.
>> `BoundAttribute` initializations of `LocalVariableTable` and `LocalVariableTypeTable` attributes do not expect invalid possible locations and cause `ClassCastException`.
>> 
>> This patch fixes `BoundAttribute` to throw `IllegalArgumentException` for invalid `LocalVariableTable` and `LocalVariableTypeTable` attributes locations. And makes `VerifierImpl` a bit more resilient to exceptions thrown from the verifier initialization.
>> 
>> Relevant test is added.
>> 
>> Please review.
>> 
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
> 
>   nit change

Marked as reviewed by liach (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20241#pullrequestreview-2188091936