RFR: 8336831: Optimize StringConcatHelper.simpleConcat [v2]

Chen Liang liach at openjdk.org
Fri Jul 19 21:25:40 UTC 2024


On Fri, 19 Jul 2024 19:18:43 GMT, Shaojin Wen <duke at openjdk.org> wrote:

>> Currently simpleConcat is implemented using mix and prepend, but in this simple scenario, it can be implemented in a simpler way and can improve performance.
>
> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   share newArray

Yep. I think this looks cleaner and avoids redundant checks on the `String.concat` path. What do you think? Is this slower according to your benchmarks?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20253#issuecomment-2240166555


More information about the core-libs-dev mailing list