RFR: 8331341: secondary_super_cache does not scale well: C1 and interpreter [v3]

[Andrew Haley]

On Thu, 11 Jul 2024 23:07:43 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Andrew Haley has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - Review feedback
>>  - Review feedback
>>  - Review feedback
>>  - Cleanup check_klass_subtype_fast_path for AArch64, deleting dead code
>
> src/hotspot/share/oops/klass.inline.hpp line 117:
> 
>> 115: }
>> 116: 
>> 117: inline bool Klass::search_secondary_supers(Klass *k) const {
> 
> I see you moved `Klass::search_secondary_supers` in `klass.inline.hpp`, but I'm not sure how it interacts with `Klass::is_subtype_of` (the sole caller) being declared in `klass.hpp`. 
> 
> Will the inlining still happen if `Klass::is_subtype_of()` callers include `klass.hpp`?

Presumably this question applies to every function in `klass.inline.hpp`?
Practically everything does `#include "oops/klass.inline.hpp"`. It's inlined in about 120 files, as far as I can see everywhere such queries are made.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19989#discussion_r1686697935