RFR: 8334755: Asymptotically faster implementation of square root algorithm [v34]

fabioromano1 duke at openjdk.org
Wed Jul 24 09:11:44 UTC 2024


On Tue, 23 Jul 2024 15:19:30 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> fabioromano1 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Conditions' order reversed in MBI.ulongSqrt()
>
> To clarify, the PR's code seems correct, but I wonder if it can be made simpler.

@rgiulietti The C code in §5.1 is correct, but it follows a logic that is slightly different from that of the pseudocode, it is less clear. Actually, the PR's code could be made simpler.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19710#issuecomment-2247310012


More information about the core-libs-dev mailing list