RFR: 8336934: Clean up JavaLangReflectAccess

[Chen Liang]

On Thu, 25 Jul 2024 21:45:21 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Removed redundant APIs in `JavaLangReflectAccess` and added general warning against using `SharedSecrets`.
>> 
>> The cleanup in `JavaLangReflectAccess` is:
>> - Converted `newConstructor` taking parameters to taking another constructor and a new accessor. The old existing API essentially does a copy and sets an accessor.
>> - Removed lots of constructor getters, unused after `newConstructor` cleanup.
>> - Removed accessor getter/setters, unused after `newConstructor` cleanup.
>> - Removed `leafCopyMethod`. We can already use `getRoot` plus `copyMethod` to achieve the same effect.
>
> The description should include a summary of the changes and the rationale.
> The Jira description is a bit better and could also be more complete.

@RogerRiggs Is the description now cleaner?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20290#issuecomment-2251513818