RFR: 8337168: Optimize LocalDateTime.toString [v4]

Shaojin Wen duke at openjdk.org
Fri Jul 26 14:37:37 UTC 2024


On Fri, 26 Jul 2024 12:25:24 GMT, Stephen Colebourne <scolebourne at openjdk.org> wrote:

> This change is fine, however the comments and performance testing assume that a date is always 10 characters long which isn't true, as the year could be greater than 9999.

The scenario where year is greater than 9999 also works. This PR does not change the logic when year is greater than 9999, so there is no additional test for >9999 or <0. 

You can submit a PR to add testcases for scenarios >9999 and <0.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20321#issuecomment-2252902661


More information about the core-libs-dev mailing list