RFR: 8336934: Clean up JavaLangReflectAccess [v2]

[Roger Riggs]

On Thu, 25 Jul 2024 22:33:44 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Removed redundant APIs in `JavaLangReflectAccess` and added general warning against using `SharedSecrets`.
>> 
>> The cleanup in `JavaLangReflectAccess` is:
>> - Converted `newConstructor` taking parameters to taking another constructor and a new accessor. The old existing API essentially does a copy and sets an accessor.
>> - Removed lots of constructor getters, unused after `newConstructor` cleanup.
>> - Removed accessor getter/setters, unused after `newConstructor` cleanup.
>> - Removed `leafCopyMethod`. We can already use `getRoot` plus `copyMethod` to achieve the same effect.
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Remove editor folds, improve comments
>  - Merge branch 'm5' into cleanup/reflect-access
>  - 8336934: Clean up JavaLangReflectAccess

looks good to me.
Thanks for the comments and updated description.

Another person familiar with the reflection implementation should review this also

-------------

Marked as reviewed by rriggs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20290#pullrequestreview-2202820120
PR Comment: https://git.openjdk.org/jdk/pull/20290#issuecomment-2253589168