RFR: 8334755: Asymptotically faster implementation of square root algorithm [v45]

[fabioromano1]

On Sat, 27 Jul 2024 14:55:04 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> fabioromano1 has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Correct test method name
>>  - Updated sqrt speed test benchmark
>
> On my M1 Pro/32 GiB
> 
> Current
> 
> Benchmark                                       Mode  Cnt        Score      Error  Units
> BigIntegerSquareRoot.testBigSqrtAndRemainder    avgt   15       45.655 ?    0.273  ns/op
> BigIntegerSquareRoot.testHugeSqrtAndRemainder   avgt   15  1200587.822 ? 7358.024  ns/op
> BigIntegerSquareRoot.testLargeSqrtAndRemainder  avgt   15       27.052 ?    0.143  ns/op
> BigIntegerSquareRoot.testSmallSqrtAndRemainder  avgt   15       33.098 ?    0.207  ns/op
> 
> 
> New
> 
> Benchmark                                       Mode  Cnt      Score    Error  Units
> BigIntegerSquareRoot.testBigSqrtAndRemainder    avgt   15     21.110 ?  0.151  ns/op
> BigIntegerSquareRoot.testHugeSqrtAndRemainder   avgt   15  21525.493 ? 36.219  ns/op
> BigIntegerSquareRoot.testLargeSqrtAndRemainder  avgt   15     14.897 ?  0.257  ns/op
> BigIntegerSquareRoot.testSmallSqrtAndRemainder  avgt   15     15.539 ?  0.146  ns/op
> 
> 
> Nice!

@rgiulietti Should the current implementation of the square root algorithm be deleted or should it be preserved?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19710#issuecomment-2254172367