RFR: 8324260: java/foreign/TestStubAllocFailure.java run timeout with -Xcomp
Aleksey Shipilev
shade at openjdk.org
Wed Jul 31 17:42:31 UTC 2024
On Wed, 31 Jul 2024 13:40:31 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
> This test spawns 2 forked processes, which then try to trigger a code cache OOM in FFM hotspot code. Even without `-Xcomp`, the test is already pretty slow, which increases dramatically with `-Xcomp`, since startup Java code has to be compiled 3 times, once for the main test process, and then 2 more times for forks.
>
> There is seemingly no/very little benefit of running this test with `-Xcomp`, since the test targets hotspot, not Java code. That and the test is sensitive to code cache usage, which is changed by `-Xcomp`.
>
> So, to avoid instabilities, this PR proposes to disable the test when running with `-Xcomp`. Another option is to not forward the VM flags of the parent process to the forks, but, on the off chance that this is useful for testing some other flags, this PR chooses the approach of disabling the test when running with `-Xcomp` instead.
Marked as reviewed by shade (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/20407#pullrequestreview-2210769865
More information about the core-libs-dev
mailing list