RFR: 7022325: TEST_BUG: test/java/util/zip/ZipFile/ReadLongZipFileName.java leaks files if it fails [v2]

Jaikiran Pai jpai at openjdk.org
Sat Jun 1 05:18:17 UTC 2024


> Can I please get a review of this test-only change which updates a couple of places in the test to use `try-with-resource`?
> 
> As noted in https://bugs.openjdk.org/browse/JDK-7022325 this change should prevent leaking of resources in case there's any failure in the test. The test continues to pass with this change.

Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:

  convert the test to junit

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19492/files
  - new: https://git.openjdk.org/jdk/pull/19492/files/3ce9ca81..b9d56006

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19492&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19492&range=00-01

  Stats: 122 lines in 1 file changed: 28 ins; 60 del; 34 mod
  Patch: https://git.openjdk.org/jdk/pull/19492.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19492/head:pull/19492

PR: https://git.openjdk.org/jdk/pull/19492


More information about the core-libs-dev mailing list