RFR: 8332457: Examine startup overheads from JDK-8294961 [v14]
Adam Sotona
asotona at openjdk.org
Mon Jun 3 12:04:29 UTC 2024
On Mon, 3 Jun 2024 11:37:34 GMT, Claes Redestad <redestad at openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>>
>> ProxyGenBench simplification
>
> test/micro/org/openjdk/bench/java/lang/reflect/Proxy/ProxyGenBench.java line 23:
>
>> 21: * questions.
>> 22: */
>> 23: package org.openjdk.bench.java.lang.reflect.Proxy;
>
> Package name needs to be lowercase. Not sure why the folder name is uppercase Proxy, but the two pre-existing benchmarks both have lower case package declarations. Uppercase letters in package names may subtly break a few tools
Yes, I've moved it down to j/l/reflect. However the existing benchmarks probably need a separate treatment.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19410#discussion_r1624297815
More information about the core-libs-dev
mailing list