RFR: 8333270: HandlersOnComplexResetUpdate and HandlersOnComplexUpdate tests fail with "Unexpected reference" if timeoutFactor is less than 1/3 [v2]

Jaikiran Pai jpai at openjdk.org
Tue Jun 4 16:47:57 UTC 2024


On Tue, 4 Jun 2024 15:17:33 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> HandlersOnComplexResetUpdate and HandlersOnComplexUpdate tests verify that loggers are GC'ed (or not GC'ed) after a reset or an update. For that they poll a ReferenceQueue in a loop. The number of iteration is adjusted according to the jtreg timeout factor. However, the logic in the test did not expect that the timeout might be less than 1.
>> 
>> This fix does two things:
>> 
>> 1. fix the adjustCount logic - so that the number of iteration can only be increased
>> 2. use remove(timeout) instead of poll() in order to minimize the waiting time.
>
> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review feedback: use Reference::refersTo consistently

The changes look good to me.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19503#pullrequestreview-2096922118


More information about the core-libs-dev mailing list