RFR: 8319457: Update jpackage to support WiX v4 and v5 on Windows [v4]
Alexey Semenyuk
asemenyuk at openjdk.org
Wed Jun 5 14:56:02 UTC 2024
On Wed, 5 Jun 2024 04:20:17 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:
>> Alexey Semenyuk has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - WixSourceConverter#applyTo should do what OverridableResource#saveToFile() does: create parent directory and replace output file if it exists.
>> - Fix issue with overwriting custom l10n file in the resource directory. All WiX source files from the resource directory should be copied to jpackage work directory before running wxi tools. jpackage should not change files in the resource directory.
>
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources.properties line 44:
>
>> 42: resource.installdirnotemptydlg-wix-file=Not empty install directory dialog WiX project file
>> 43: resource.launcher-as-service-wix-file=Service installer WiX project file
>> 44: resource.wix-src-conv=XSLT stylesheet converting WiX sources from WiX v3 to WiX v4 format
>
> WiX v4 -> WiX v4/v5
The converter does exactly as described, it converts WiX v3 sources into WiX v4 **format** that can be used with WiX v4 and WiX v5. So I believe the description should remain unchanged.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19318#discussion_r1627942141
More information about the core-libs-dev
mailing list