RFR: 8333774: Avoid eagerly loading various EmptySpliterator classes [v2]

Chen Liang liach at openjdk.org
Fri Jun 7 12:58:16 UTC 2024


On Fri, 7 Jun 2024 12:38:24 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Trivially move a few private static finals to their respective source type to avoid eagerly loading a few small classes.
>
> Claes Redestad has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - revert typo
>  - Copyright

Marked as reviewed by liach (Author).

src/java.base/share/classes/java/util/Spliterators.java line 89:

> 87:     }
> 88: 
> 89: 

Suggestion:


Bikeshedding to the extreme (yes, I looked for why the deletion had one less line)

-------------

PR Review: https://git.openjdk.org/jdk/pull/19591#pullrequestreview-2104476389
PR Review Comment: https://git.openjdk.org/jdk/pull/19591#discussion_r1631160491


More information about the core-libs-dev mailing list