RFR: 8333749: Consolidate ConstantDesc conversion in java.base [v6]

ExE Boss duke at openjdk.org
Fri Jun 7 18:30:14 UTC 2024


On Fri, 7 Jun 2024 13:56:24 GMT, Chen Liang <liach at openjdk.org> wrote:

>> In java.base, especially in bytecode generators, we have many different methods converting known valid Class and MethodType into ClassDesc and MethodTypeDesc. These conversions should be consolidated into the same utility method for the ease of future maintenance.
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   ExE-Boss review, go through validated path in Class

`ClassDesc​::of​(String)`, `ClassDesc​::of​(String, String)`, and `ClassDesc​::ofInternalName​(String)` can probably call `ReferenceClassDescImpl​::ofValidated​(String)` directly as those methods already perform validation before forwarding to `ClassDesc​::ofDescriptor​(String)`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19585#issuecomment-2155321459


More information about the core-libs-dev mailing list