RFR: 8333833: UUID toString removes the use of ByteArrayLittleEndian [v2]
Brett Okken
duke at openjdk.org
Sat Jun 8 15:54:15 UTC 2024
On Sat, 8 Jun 2024 06:40:39 GMT, Shaojin Wen <duke at openjdk.org> wrote:
>> After PR #16245, C2 optimizes stores into primitive arrays by combining values into larger stores. In the UUID.toString method, ByteArrayLittleEndian can be removed, making the code more elegant and faster.
>
> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
>
> add comments
src/java.base/share/classes/jdk/internal/util/HexDigits.java line 117:
> 115:
> 116: /**
> 117: * Insert the int into the buffer as 4 hexadecimal digits
4 hex digits is 2 bytes, right?
should this take a short instead?
At a minimum, seems documentation should be clear as to which 2 bytes are used.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19610#discussion_r1632064197
More information about the core-libs-dev
mailing list