RFR: 8333833: UUID toString removes the use of ByteArrayLittleEndian [v6]

Claes Redestad redestad at openjdk.org
Mon Jun 10 07:32:27 UTC 2024


On Sun, 9 Jun 2024 22:45:26 GMT, Shaojin Wen <duke at openjdk.org> wrote:

>> After PR #16245, C2 optimizes stores into primitive arrays by combining values ​​into larger stores. In the UUID.toString method, ByteArrayLittleEndian can be removed, making the code more elegant and faster.
>
> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   better parameter names

src/java.base/share/classes/jdk/internal/util/HexDigits.java line 118:

> 116:     /**
> 117:      * Insert the unsigned 2-byte integer into the buffer as 4 hexadecimal digit ASCII bytes,
> 118:      * only least significant 16 bits of {@code i} are used.

Suggestion:

     * only least significant 16 bits of {@code value} are used.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19610#discussion_r1632711983


More information about the core-libs-dev mailing list