RFR: 8332400: isspace argument should be a valid unsigned char

David Holmes dholmes at openjdk.org
Tue Jun 11 01:19:12 UTC 2024


On Mon, 10 Jun 2024 13:36:06 GMT, Robert Toyonaga <duke at openjdk.org> wrote:

> But what about when an int is passed to isspace?

The current casts to int are incorrect as a negative value would be sign-extended and then fail the range check. I think we have to cast to unsigned char in all cases in the caller, which renders the wrapper and range-check obsolete AFAICS.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19567#issuecomment-2159586765


More information about the core-libs-dev mailing list