RFR: 8333893: Optimization for StringBuilder append boolean & null [v4]

Tue Jun 11 15:38:14 UTC 2024

On Tue, 11 Jun 2024 12:11:21 GMT, Shaojin Wen <duke at openjdk.org> wrote:

>> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   revert
>
> ([f96cde4e](https://git.openjdk.org/jdk/pull/19626/files/f96cde4e79e12e2ea46e6061f918a69f11d59985)) ([0cbaa5ac](https://git.openjdk.org/jdk/pull/19626/files/0cbaa5ac04873373131f1a7216353a5af5b3e48e)) The previous overriding of StringUTF16.putChar method did not improve performance, so I reverted to the original version.
> 
> I have collected information on TraceMergeStores, but I don't have enough knowledge to analyze it yet
> 
> https://github.com/wenshao/jdk/wiki/pr19626_appendNull_0

@wenshao have you published info about `TraceMergeStores` somewhere? It is very well possible that the optimization does not apply in your code. Then you would need to dig into the VM code and see why.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19626#issuecomment-2161066866