Integrated: 8333714: Cleanup the usages of CHECK_EXCEPTION_NULL_FAIL macro in java launcher

Jaikiran Pai jpai at openjdk.org
Fri Jun 14 12:51:20 UTC 2024


On Thu, 6 Jun 2024 11:53:10 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review for this change which proposes to remove the `CHECK_EXCEPTION_NULL_FAIL` macro from the `java` launcher code?
> 
> This addresses https://bugs.openjdk.org/browse/JDK-8333714. As noted in that JBS issue, in a recent PR discussion, it was suggested https://github.com/openjdk/jdk/pull/18786#issuecomment-2147452633 that this macro should be removed and the failure of a JNI specified operation (the ones for which this macro is being used) should be determined based on a `NULL` value returned from that function. The commit in this PR removes this macros and updates the call sites to do a `NULL` check.
> 
> Given the nature of this change, no new tests have been added. tier1, tier2 and tier3 testing passed successfully with these changes.

This pull request has now been integrated.

Changeset: efab48c0
Author:    Jaikiran Pai <jpai at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/efab48c06554476eae7a7bd946dee033d16a9c38
Stats:     68 lines in 1 file changed: 37 ins; 9 del; 22 mod

8333714: Cleanup the usages of CHECK_EXCEPTION_NULL_FAIL macro in java launcher

Reviewed-by: alanb

-------------

PR: https://git.openjdk.org/jdk/pull/19576


More information about the core-libs-dev mailing list