RFR: 8294960: Convert java.base/java.lang.invoke package to use the Classfile API to generate lambdas and method handles [v18]

Adam Sotona asotona at openjdk.org
Mon Jun 17 14:05:29 UTC 2024


On Wed, 12 Jun 2024 20:27:05 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - reverted static initialization of ConstantPoolBuilder and CP entries
>>  - fixed naming conventions
>
> src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java line 1148:
> 
>> 1146:     }
>> 1147: 
>> 1148:     private void emitPopInsn(CodeBuilder cob, BasicType type) {
> 
> We need a TypeKind-aware pop in CodeBuilder too :(

Yes, it would be helpful.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17108#discussion_r1642870775


More information about the core-libs-dev mailing list