RFR: 8333854: IllegalAccessError with proxies after JDK-8332457 [v5]

[Adam Sotona]

On Thu, 13 Jun 2024 14:11:48 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Please review this patch that fixes a critical issue that breaks some Proxy usages.
>> 
>> Since the problematic patch from before cannot be backed out, this patch aims to emulate the old behavior before. A diff between before the problematic patch and this patch is available at https://gist.github.com/7565b2091008f561eb0ada019bc5e517, generated by running `git diff 326dbb1b139dd1ec1b8605339b91697cdf49da9a -- src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java`.
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   methodField can be initialized eagerly

It is unfortunate that LDC of a CP entry cannot substitute the original complex approach (and the critical cases were not covered by any tests).

@liach great work on the restoration of the original approach, while keeping the other improvements
Thanks!

-------------

Marked as reviewed by asotona (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19615#pullrequestreview-2124720977