RFR: 8334755: Asymptotically faster implementation of square root algorithm [v5]
Daniel Jeliński
djelinski at openjdk.org
Sun Jun 23 06:22:18 UTC 2024
On Tue, 18 Jun 2024 15:34:16 GMT, fabioromano1 <duke at openjdk.org> wrote:
>> fabioromano1 has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Removed unused import
>
> src/java.base/share/classes/java/math/MutableBigInteger.java line 293:
>
>> 291: */
>> 292: private int compareShifted(MutableBigInteger b, int ints) {
>> 293: this.normalize();
>
> See [JDK-8334483](http://bugs.java.com/bugdatabase/view_bug?bug_id=JDK-8334483)
It is the responsibility of the caller to ensure that the parameters are normalized. Calling normalize isn't free, and it's usually easy to tell when a number needs to be normalized.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19710#discussion_r1649935313
More information about the core-libs-dev
mailing list