RFR: 8334755: Asymptotically faster implementation of square root algorithm [v5]
fabioromano1
duke at openjdk.org
Sun Jun 23 09:56:09 UTC 2024
On Sun, 23 Jun 2024 09:48:59 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
> Most likely. If you check the code you'll notice that most methods that change the `MutableBigInteger` value (like `subtract`) call `normalize` after performing the operation, so the values should be normalized most of the time.
@djelinski Unfortunately, this is not always true. In fact, without forcing normalization before comparing, the program leads to failure in thousands of cases, while forcing the normalization resolves all the failures...
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19710#discussion_r1650033332
More information about the core-libs-dev
mailing list