RFR: 8334755: Asymptotically faster implementation of square root algorithm [v5]
fabioromano1
duke at openjdk.org
Sun Jun 23 14:15:11 UTC 2024
On Sun, 23 Jun 2024 06:19:17 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
>> fabioromano1 has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Removed unused import
>
> Thanks for contributing to the OpenJDK!
> What tests did you run for this change? How did you compare the performance of the new vs the original method? How can we reproduce the results?
>
> Please add a JMH benchmark for your changes. JMH benchmarks are the standard method of evaluating performance improvements.
@djelinski Just added a JMH benchmark to evaluate the performance improvement.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19710#issuecomment-2185006281
More information about the core-libs-dev
mailing list