RFR: 8335110: Fix instruction name and API spec inconsistencies in CodeBuilder [v2]
Adam Sotona
asotona at openjdk.org
Wed Jun 26 09:22:10 UTC 2024
On Tue, 25 Jun 2024 21:22:34 GMT, Chen Liang <liach at openjdk.org> wrote:
>> This is a collection of fixes and improvements to CodeBuilder, plus 2 renames.
>>
>> Fixes include:
>> 1. `CodeBuilder::receiverSlot` typo
>> 2. `CodeAttribute::labelToBci` update spec
>> 3. `CodeBuilder::exceptionCatch` implementation
>> 4. `CodeBuilder::if_nonnull`/`if_null` -> `ifnonnull`/`ifnull`
>> 5. Docs for what instructions factories emit, and to explain why some factories have name mismatch; also a section in summary.
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
>
> Patch in csr but forgot to upload
Looks good to me, thank you.
-------------
Marked as reviewed by asotona (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19889#pullrequestreview-2141230227
More information about the core-libs-dev
mailing list