RFR: 8332072: Convert package.html files in `java.naming` to package-info.java [v2]

Wed Jun 26 18:11:45 UTC 2024

On Wed, 26 Jun 2024 18:09:10 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Can I please get a review for this small change? The motivation is that javac does not recognize `package.html` files.
>> 
>> The conversion was simple, I used a script to rename the files, append "*" on the left and remove some HTML tags like `<body>` and `<html>`. I did the conversion in place, renaming them in git but with the big amount of change `git` thinks it's a new file.
>> 
>> I also added a new `package-info.java` file to `javax.naming.ldap.spi`. I hope that's fine.
>
> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - use javadoc standards
>  - Merge remote-tracking branch 'upstream/master' into naming
>  - remove whitespace
>  - 8332072: Convert package.html files in `java.naming` to package-info.java

I have converted this to use some of the now-current javadoc convetions.

src/java.naming/share/classes/javax/naming/ldap/package-info.java line 200:

> 198:  * if (respCtls != null) {
> 199:  *     // Find the one we want
> 200:  *     for (int i = 0; i < respCtls.length; i++) {

This is the only change that isn't a direct 1:1 conversion, I hope this ok.

-------------

PR Review: https://git.openjdk.org/jdk/pull/19529#pullrequestreview-2142622498
PR Review Comment: https://git.openjdk.org/jdk/pull/19529#discussion_r1655320955