RFR: 8326915: NPE when a validating parser is restricted [v2]

Joe Wang joehw at openjdk.org
Fri Mar 1 18:02:24 UTC 2024


On Fri, 1 Mar 2024 00:53:17 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Joe Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   input.substring second argument not needed; proper test method name
>
> src/java.xml/share/classes/jdk/xml/internal/SecuritySupport.java line 402:
> 
>> 400:         int i = input.lastIndexOf('/');
>> 401:         if (i > 0) {
>> 402:             return input.substring(i+1, input.length());
> 
> Nit: the second argument is not needed.

Thanks. Fixed. Also replaced the test's method name with a proper name.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18071#discussion_r1509351975


More information about the core-libs-dev mailing list